Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: handle block size max #1771

Closed
buck54321 opened this issue Aug 9, 2022 · 1 comment · Fixed by #1894
Closed

eth: handle block size max #1771

buck54321 opened this issue Aug 9, 2022 · 1 comment · Fixed by #1894
Labels
ETH solution needed wallet Client wallet backends

Comments

@buck54321
Copy link
Member

I does seem limited, but considering that a regular tx is 21,000 gas, I think it's correct.

Back to the gas estimate issue, I think this means we should place a cap on the number of inits.

More broadly, it sounds like we need to place a cap on the number of lots otherwise there will be potentially unswappable orders, however huge they'd be.

Originally posted by @chappjc in #1622 (comment)


Just spitballin'. Either...

  1. Place a cap on number of lots in the dex protocol or at the server configuration level
  2. Break up large swap internally to eth, which will carry a lot of complexity especially around errors.
  3. Handle it in *Core, which may end up being the easiest, implementation-wise, but it's really just an ethereum thing.
@martonp
Copy link
Contributor

martonp commented Oct 6, 2022

I'll work on this. I think the third plan of handling it in Core is the best. Each wallet can specify what their limit is and core can do the batching based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ETH solution needed wallet Client wallet backends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants