Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/core: Popuplate AssetConfig on PreRedeem call #1713

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

martonp
Copy link
Contributor

@martonp martonp commented Jul 16, 2022

The asset config was not populated when calling PreRedeem in MaxSell. This was causing a panic.

The asset config was not populated when calling PreRedeem in MaxSell.
This was causing a panic.
@chappjc
Copy link
Member

chappjc commented Jul 16, 2022

Resolves #1696, although @buck54321 has this in PR #1622

Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but I'm going to focus on #1622 now so we can get other fixes in with that.

@chappjc chappjc merged commit a2bd6cf into decred:master Jul 19, 2022
@chappjc chappjc added this to the 0.5 milestone Aug 26, 2022
@chappjc chappjc added the ETH label Aug 26, 2022
@martonp martonp deleted the preRedeemErr branch December 20, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants