Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong behavior showing proposals on map #236

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix wrong behavior showing proposals on map #236

merged 1 commit into from
Sep 25, 2023

Conversation

fblupi
Copy link
Contributor

@fblupi fblupi commented Sep 21, 2023

Fixes #235.

This issue appeared after merging #225 as there was a bug in the solution that made the visibility of the proposal the same as the configured for "not answered" when the state of the proposal is set as false.

@fblupi fblupi added the bug Something isn't working label Sep 21, 2023
@fblupi fblupi requested a review from microstudi September 21, 2023 10:04
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head d507dda differs from pull request most recent head d6e22c3. Consider uploading reports for the commit d6e22c3 to get more accurate results

📢 Thoughts on this report? Let us know!.

@fblupi fblupi marked this pull request as draft September 21, 2023 10:32
@fblupi fblupi marked this pull request as ready for review September 21, 2023 12:22
Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@microstudi microstudi merged commit 25d2e7f into main Sep 25, 2023
9 of 10 checks passed
@microstudi microstudi deleted the fix/235 branch September 25, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awesome Map: wrong behavior showing proposals
2 participants