Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup migrations and models #13

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

microstudi
Copy link

@microstudi microstudi commented Oct 6, 2023

  • Create migrations
  • Create models
  • Spec for models:
    • Standard checks
    • Check for auto-refresh cache table on vote change (created, updated, destroyed)

Fixes Green-Party-of-Canada-Members/gpc-decidim#111

@microstudi microstudi changed the base branch from develop to graded_proposal_voting October 6, 2023 12:02
@microstudi microstudi force-pushed the graded_proposal_voting branch from 25d2e7f to 10958f9 Compare October 6, 2023 12:04
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (graded_proposal_voting@5a99411). Click here to learn what that means.

❗ Current head 67a7e20 differs from pull request most recent head ed597b3. Consider uploading reports for the commit ed597b3 to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                    @@
##             graded_proposal_voting      #13   +/-   ##
=========================================================
  Coverage                          ?   28.63%           
=========================================================
  Files                             ?      101           
  Lines                             ?     3279           
  Branches                          ?        0           
=========================================================
  Hits                              ?      939           
  Misses                            ?     2340           
  Partials                          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@microstudi microstudi merged commit 5c7a1ba into graded_proposal_voting Oct 10, 2023
2 of 10 checks passed
@microstudi microstudi mentioned this pull request Oct 10, 2023
6 tasks
microstudi added a commit that referenced this pull request Nov 2, 2023
* Setup migrations and models (#13)

* add migrations

* change grade to weight

* totals name

* hooks (wip)

* add total weight cache

* graded voting/set defaults (#14)

* initial defaults

* add deface

* add views to manifest

* add cells view hacker

* set weight validator for voting manifest

* test fixing

* add basic weight voting

* add specs

* manifest spec

* add controller spec

* add readme

* fix awesome spec

* rubocop

* fix system checker spec

* set openstreet map

* used mocked openstreet maps

* modernize actions

* Prevent changin voting manifest if votes exist (#16)

* update codecov report

* Export weights (#17)

* add label generation for the manifest

* tweak exported

* add weights to the exporter

* fix tests

* add graphql entry

* Order proposals by my votes (#18)

* override filters

* add specs

* FrontEnd vote action UI/implementation (#15)

* add vote button, add modal, change votes counter view

* change frontend

* add voting to modal

* add action cable, updating results

* refactoring

* isolate the specific implementation of the voting

* add abstain setting

* change modal, change voting

* add abstain to voting

* refactoring

* change weight colors

* add tests

* add cells specs

* fix lint

* fix stylelint

* normalize locale

* change controller

* fix proposal_vote_path

* fix locale

* fix locale

---------

Co-authored-by: Ivan Vergés <[email protected]>

* Minor fixes and improvements for frontend voting (#19)

* change basic copies

* namespace css

* add link "change my vote"

* change opacity method

* add tests

* add check settings for abstain

* fix cell test

---------

Co-authored-by: Anna Topalidi <[email protected]>

* Add modal window with instructions (#20)

* change basic copies

* namespace css

* introduce modal pre-voting

* handle localstorage

* refactor namespaces for copies

* fix copy

* copies

* add finger

* add svg icons

* add margin

* fix margins in modal

* abstain style

* fix tests

* prevent voting abstain if not allowed

* fix footer

* normalize i18n

* add additional specs

* add conf var for sorting

* fix cache proposal_m

* proposal conf fixes

* Rename manifest and minor fixes (#22)

* rename voting_cards manifest

* mend

* abstain color

* fix modal title

* fix test

* fix counter colors

* fix xss

* style fix

---------

Co-authored-by: Anna Topalidi <[email protected]>
Co-authored-by: Anna Topalidi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant