Add modal window with instructions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## graded_proposal_voting #20 +/- ##
=========================================================
Coverage ? 60.79%
=========================================================
Files ? 55
Lines ? 1584
Branches ? 0
=========================================================
Hits ? 963
Misses ? 621
Partials ? 0 ☔ View full report in Codecov by Sentry. |
# Conflicts: # app/cells/decidim/decidim_awesome/voting/three_flags_proposal/show.erb # app/cells/decidim/decidim_awesome/voting/three_flags_proposal/vote_block_for.erb # app/views/decidim/decidim_awesome/voting/three_flags/_show_vote_button.html.erb # config/locales/en.yml
microstudi
added a commit
that referenced
this pull request
Nov 2, 2023
* Setup migrations and models (#13) * add migrations * change grade to weight * totals name * hooks (wip) * add total weight cache * graded voting/set defaults (#14) * initial defaults * add deface * add views to manifest * add cells view hacker * set weight validator for voting manifest * test fixing * add basic weight voting * add specs * manifest spec * add controller spec * add readme * fix awesome spec * rubocop * fix system checker spec * set openstreet map * used mocked openstreet maps * modernize actions * Prevent changin voting manifest if votes exist (#16) * update codecov report * Export weights (#17) * add label generation for the manifest * tweak exported * add weights to the exporter * fix tests * add graphql entry * Order proposals by my votes (#18) * override filters * add specs * FrontEnd vote action UI/implementation (#15) * add vote button, add modal, change votes counter view * change frontend * add voting to modal * add action cable, updating results * refactoring * isolate the specific implementation of the voting * add abstain setting * change modal, change voting * add abstain to voting * refactoring * change weight colors * add tests * add cells specs * fix lint * fix stylelint * normalize locale * change controller * fix proposal_vote_path * fix locale * fix locale --------- Co-authored-by: Ivan Vergés <[email protected]> * Minor fixes and improvements for frontend voting (#19) * change basic copies * namespace css * add link "change my vote" * change opacity method * add tests * add check settings for abstain * fix cell test --------- Co-authored-by: Anna Topalidi <[email protected]> * Add modal window with instructions (#20) * change basic copies * namespace css * introduce modal pre-voting * handle localstorage * refactor namespaces for copies * fix copy * copies * add finger * add svg icons * add margin * fix margins in modal * abstain style * fix tests * prevent voting abstain if not allowed * fix footer * normalize i18n * add additional specs * add conf var for sorting * fix cache proposal_m * proposal conf fixes * Rename manifest and minor fixes (#22) * rename voting_cards manifest * mend * abstain color * fix modal title * fix test * fix counter colors * fix xss * style fix --------- Co-authored-by: Anna Topalidi <[email protected]> Co-authored-by: Anna Topalidi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: