generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SyncManager to Web5 Managed Agent #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lsQuery Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
…rt/stop methods, fix bug in messageExists, add missing await to addMessage() and setWatermark() Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
This was
linked to
issues
Aug 30, 2023
Closed
mistermoe
reviewed
Aug 31, 2023
mistermoe
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
force-pushed
the
sync-manager
branch
from
September 1, 2023 00:19
ae5e696
to
541e418
Compare
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
force-pushed
the
sync-manager
branch
from
September 1, 2023 00:35
e0c099a
to
49d8826
Compare
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 90.28% 89.42% -0.86%
==========================================
Files 63 64 +1
Lines 11592 12399 +807
Branches 1132 1188 +56
==========================================
+ Hits 10466 11088 +622
- Misses 1106 1291 +185
Partials 20 20
|
This was referenced Sep 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
push()
andpull()
. Testing for more scenarios and edge cases is needed, which is tracked in Issue Improve test coverage for SyncManager #206DwnManager
that should be refactored as tracked in Issue Refactoring needed forDwnManager
andSyncManager
#205.SyncManager
to the tests / test agents.@web5/agent
package forDwnManager
handlingEventsGet
,MessagesGet
,ProtocolsConfigure
, andProtocolsQuery
.@web5/api
package forProtocol
.