Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sync configurable #95

Closed
frankhinek opened this issue May 28, 2023 · 2 comments · Fixed by #204
Closed

Make sync configurable #95

frankhinek opened this issue May 28, 2023 · 2 comments · Fixed by #204
Assignees
Labels
enhancement New feature or request

Comments

@frankhinek
Copy link
Contributor

Sync should be configurable and this feature was requested by multiple community members (example below).

Screenshot 2023-05-22 at 1 19 10 PM
@mistermoe
Copy link
Contributor

initial semi-delirious thoughts:

const { web5, did } = await Web5.connect({
  techPreview: {
    sync: '5m' | true | false
  }
});
  • value provided for sync can be a boolean or a string.
  • if string, value is parsed by https://www.npmjs.com/package/ms.
  • if false, toggles sync off entirely
  • if true, toggles sync on with default interval of 1m (totally down for default to be longer)
  • defaults to true
  • the reason i put the option in techPreview is because i think configuring sync's interval is actually an agent configuration that wouldn't be controlled by web5. imagine alice using multiple web5 apps that are all constantly clobbering s single sync interval for some remote agent
  • def lmk if allowing for boolean + hipster string time format feels too "cute".

@mistermoe
Copy link
Contributor

another relevant discord discussion starts here

@mistermoe mistermoe linked a pull request Jun 13, 2023 that will close this issue
@frankhinek frankhinek self-assigned this Aug 28, 2023
@frankhinek frankhinek moved this to In Progress in Web5 Roadmap Aug 28, 2023
@frankhinek frankhinek linked a pull request Aug 30, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web5 Roadmap Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants