Add support for compressed secp256k1 publicKey #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroaki KAWAI <[email protected]>
…sage. Signed-off-by: Hiroaki KAWAI <[email protected]>
Signed-off-by: Hiroaki KAWAI <[email protected]>
hkwi
requested review from
mistermoe,
csuwildcat,
thehenrytsai and
diehuxx
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
added 3 commits
October 18, 2023 16:31
* main: Replace `handle<Xyz>` methods in `Dwn` class with overloaded `process… (decentralized-identity#566)
diehuxx
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Thanks for the contribution! This looks good to me, though I'm going to wait for @thehenrytsai to take a look before merging, to double check this covers what he expects.
thehenrytsai
approved these changes
Oct 20, 2023
diehuxx
pushed a commit
that referenced
this pull request
Oct 20, 2023
* main: Add codecov coverage job in `integrity-check.yml` (#542) Add support for compressed secp256k1 publicKey (#567) Add range filter support for dataSize (#568) Replace `handle<Xyz>` methods in `Dwn` class with overloaded `process… (#566) Add tests for error cases in did-resolver.spec.ts (#561) add browser tests to gh actions. (#541)
thehenrytsai
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated eciesjs library, that now supports compressed secp256k1 public key, and adjusted codes.
Converted key creation methods to produce compressed secp256k1 public key.
Resolves #397