Replace handle<Xyz> methods in Dwn class with overloaded `process…
#566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Message` This commit fixes decentralized-identity#563. It removes the four methods in `Dwn` (1) `handleRecordsWrite` (2) `handleRecordsQuery` (3) `handleRecordsRead` (4) `handleMessagesGet` with the overloaded `processMessage` function introduced in commit decentralized-identity#554. This commit also replaces all invocations of the four deleted functions in all tests with the single `processMessage`. Note that because the new `processMessage` can't and doesn't use the `expectedMethod` or `expectedInterface` arguments in `validateMessageIntegrity`, any tests that are testing for incorrect method edge cases will receive errors from json schema invalidation (i.e., `schema for x not found`) rather than message integrity errors (i.e., `Expected method x, received y)
shobitb
requested review from
mistermoe,
csuwildcat,
thehenrytsai and
diehuxx
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
diehuxx
approved these changes
Oct 18, 2023
diehuxx
pushed a commit
to hkwi/dwn-sdk-js
that referenced
this pull request
Oct 18, 2023
* main: Replace `handle<Xyz>` methods in `Dwn` class with overloaded `process… (decentralized-identity#566)
EbonyLouis
added
the
hacktoberfest-accepted
diehuxx
pushed a commit
that referenced
this pull request
Oct 20, 2023
* main: Add codecov coverage job in `integrity-check.yml` (#542) Add support for compressed secp256k1 publicKey (#567) Add range filter support for dataSize (#568) Replace `handle<Xyz>` methods in `Dwn` class with overloaded `process… (#566) Add tests for error cases in did-resolver.spec.ts (#561) add browser tests to gh actions. (#541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Message`
This commit fixes #563. It replaces the four methods in
Dwn(1)handleRecordsWrite(2)handleRecordsQuery(3)handleRecordsRead(4)handleMessagesGetwith the overloadedprocessMessagefunction introduced in commit #554.This commit also replaces all invocations of the four deleted functions in all tests with the single
processMessage. Note that because the newprocessMessagecan't and doesn't use theexpectedMethodorexpectedInterfacearguments invalidateMessageIntegrity, any tests that are testing for incorrect method edge cases will receive errors from json schema invalidation (i.e.,schema for x not found) rather than message integrity errors (i.e.,Expected method x, received y)