Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov coverage job in integrity-check.yml #542

Merged
merged 7 commits into from
Oct 20, 2023

Conversation

0scvr
Copy link
Contributor

@0scvr 0scvr commented Oct 5, 2023

Added Codecov to the CI pipeline to display test coverage on pull requests and on Readme badge.

See #534.

@codesandbox
Copy link

codesandbox bot commented Oct 5, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@thehenrytsai
Copy link
Contributor

@0scvr, I've enabled workflow for this PR, so hopefully this will be sufficient for validating your changes!

@0scvr 0scvr marked this pull request as ready for review October 6, 2023 20:28
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's on the right path! Checking off one of the minbar requirements:

  • The README.md shows the latest updated code coverage numbers.
  • Showing code coverage delta/difference for each submitted PR.
  • Have a customized codecov.yml tailored to our needs:
    1. Require 100% coverage on new code
    2. Require coverage to never drop
    3. Exclude interface/type files if needed

@0scvr
Copy link
Contributor Author

0scvr commented Oct 16, 2023

@thehenrytsai Could you try running the build job again to see if it works/what needs changing please ?

Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the yml config file. Last thing left is to update the README!

@0scvr
Copy link
Contributor Author

0scvr commented Oct 16, 2023

Thanks for adding the yml config file. Last thing left is to update the README!

Should be done now, but you might need to add ?token=XXXXX add the end of the URL if coverage doesn't appear after merge.

Here's some instructions on how to do that https://docs.codecov.com/docs/status-badges

thehenrytsai
thehenrytsai previously approved these changes Oct 17, 2023
thehenrytsai
thehenrytsai previously approved these changes Oct 20, 2023
@thehenrytsai thehenrytsai merged commit e5a1a31 into decentralized-identity:main Oct 20, 2023
4 checks passed
diehuxx pushed a commit that referenced this pull request Oct 20, 2023
* main:
  Add codecov coverage job in `integrity-check.yml` (#542)
  Add support for compressed secp256k1 publicKey (#567)
  Add range filter support for dataSize (#568)
  Replace `handle<Xyz>` methods in `Dwn` class with overloaded `process… (#566)
  Add tests for error cases in did-resolver.spec.ts (#561)
  add browser tests to gh actions. (#541)
@thehenrytsai thehenrytsai added the hacktoberfest-accepted Accepted PRs for the hacking month of October label Oct 23, 2023
diehuxx pushed a commit that referenced this pull request Oct 23, 2023
* main:
  Add codecov coverage job in `integrity-check.yml` (#542)
  Add support for compressed secp256k1 publicKey (#567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted PRs for the hacking month of October
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants