-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codecov coverage job in integrity-check.yml
#542
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
@0scvr, I've enabled workflow for this PR, so hopefully this will be sufficient for validating your changes! |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's on the right path! Checking off one of the minbar requirements:
- The README.md shows the latest updated code coverage numbers.
- Showing code coverage delta/difference for each submitted PR.
- Have a customized
codecov.yml
tailored to our needs:- Require 100% coverage on new code
- Require coverage to never drop
- Exclude interface/type files if needed
@thehenrytsai Could you try running the build job again to see if it works/what needs changing please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the yml config file. Last thing left is to update the README!
Signed-off-by: 0scvr <[email protected]>
Should be done now, but you might need to add Here's some instructions on how to do that https://docs.codecov.com/docs/status-badges |
* main: Add codecov coverage job in `integrity-check.yml` (#542) Add support for compressed secp256k1 publicKey (#567) Add range filter support for dataSize (#568) Replace `handle<Xyz>` methods in `Dwn` class with overloaded `process… (#566) Add tests for error cases in did-resolver.spec.ts (#561) add browser tests to gh actions. (#541)
Added Codecov to the CI pipeline to display test coverage on pull requests and on Readme badge.
See #534.