Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish internal build workflow #735

Merged
merged 13 commits into from
Mar 26, 2024
Merged

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Mar 20, 2024

Problem

We need a workflow that calls the internal build release workflow found here.

Solution

This PR adds the file and documents the what/how/why.

Proof of the build process working:
image

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Mar 20, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@VersusFacit VersusFacit marked this pull request as ready for review March 20, 2024 21:37
@VersusFacit
Copy link
Contributor Author

This workflow is working with test :D

Documentation added.

It's fully ready to be reviewed and considered done with this PR.

@VersusFacit VersusFacit changed the title Finish internal build. Finish internal build workflow Mar 20, 2024
@VersusFacit VersusFacit requested a review from emmyoop March 20, 2024 21:39
@VersusFacit VersusFacit self-assigned this Mar 20, 2024
@VersusFacit VersusFacit requested a review from mikealfare March 20, 2024 21:39
@VersusFacit VersusFacit added Skip Changelog Skips GHA to check for changelog file and removed Skip Changelog Skips GHA to check for changelog file labels Mar 20, 2024
@@ -28,7 +40,7 @@ jobs:
invoke-reusable-workflow:
name: "Build and Release Internally"

uses: "VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main"
uses: "dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@mp/finish_internal_workflow"
Copy link
Contributor Author

@VersusFacit VersusFacit Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to change this once main has all the changes needed to support all the other workflows. Since this PR's workflow can be invoked using the branch reference, I'll merge at the time I can revert to main (unless there is an alternate path desired)

@mikealfare
Copy link
Contributor

FYI, the failing integration tests are the usual flaky tests, and don't seem related to this PR.

.github/workflows/release-internal.yml Outdated Show resolved Hide resolved
.github/workflows/release-internal.yml Outdated Show resolved Hide resolved
@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Mar 26, 2024
@VersusFacit
Copy link
Contributor Author

https://github.com/dbt-labs/dbt-redshift/actions/runs/8443805653 is the clean build for the latest sha

@VersusFacit VersusFacit merged commit be1a252 into main Mar 26, 2024
37 checks passed
@VersusFacit VersusFacit deleted the mp/finish_internal_workflow branch March 26, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants