Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish internal build workflow #1143

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Finish internal build workflow #1143

merged 9 commits into from
Mar 26, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Mar 21, 2024 •
edited
Loading

Problem

We need a workflow that calls the internal build release workflow found here.

Solution

This PR adds the file and documents the what/how/why.

Proof of the build process working:

image

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Mar 21, 2024
@cla-bot cla-bot bot added the cla:yes label Mar 21, 2024
VersusFacit
VersusFacit commented Mar 21, 2024
View reviewed changes
.github/workflows/release-internal.yml Outdated

uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main
uses: "dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@mp/finish_internal_workflow"
Copy link
Contributor Author

@VersusFacit VersusFacit Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to change this once main has all the changes needed to support all the other workflows. Since this PR's workflow can be invoked using the branch reference, I'll merge at the time I can revert to main (unless there is an alternate path desired)

@VersusFacit VersusFacit changed the title Add release internal workflow Finish internal build workflow Mar 21, 2024
emmyoop
emmyoop approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but same comments as dbt-labs/dbt-redshift#735

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Mar 26, 2024
@VersusFacit
Copy link
Contributor Author

Clean build for latest sha here: https://github.com/dbt-labs/dbt-bigquery/actions/runs/8443816013

@VersusFacit VersusFacit merged commit e98ee4c into main Mar 26, 2024
37 checks passed
@VersusFacit VersusFacit deleted the add_release_internal_workflow branch March 26, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@emmyoop emmyoop emmyoop approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VersusFacit @emmyoop @mikealfare