Finish internal build pipeline reusable workflow

[VersusFacit]

resolves 38 in the epic

Description

Finish this up for 1p repos.

• Better docs throughout
• Use env vars to minimize string literals
  • Code this in such a way that we only have to edit one literal when moving more adapters over the hatch
• Add conditional testing for different adapters

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue

[VersusFacit]

@mikealfare suggested we make this an env var but this is impossible based on how the execution runtime works. I tried about 5 other options (see commit history) and very simply none worked. It's because GHA has limited execution flow options with needs. This key word is required to maintain order of execution, but as soon as you add it, you start having trouble with other mechanisms for conditional execution. But then also reusable workflows like the Postgres testing one must be invoked at the job level another step level so I can't use a conditional check inside of a job. Basically, my hands are tied on exactly what I can do and this is a way I can keep things working for now.

When we get this merged and I try mixing in the 3p repo changes, I can attempt to rework things to be better here.

[emmyoop]

Overall looks great. There is one blocker with the conditional logic on building.

[emmyoop]

This feels overly complicated. If HATCH_ADAPTERS is just a space delimited list you can just check that the dbms is in the list:

          if [[ " ${{ env.HATCH_ADAPTERS}} " =~ " ${{ inputs.dbms_name }} " ]]; then
              echo "is_hatch_adapter=true" >> $GITHUB_OUTPUT
          else
              echo "is_hatch_adapter=false" >> $GITHUB_OUTPUT
          fi

I'm also fine with leaving this for now and simplifying it at a future date. Not a blocker.

[VersusFacit]

Let me address in the upcoming round 2 which will add third party support. But geez okay this is news to me. For what it's worth, I went with a comment delimited list as the goal but I realize now it's more bash idiomatic to use the space delimited list. It's rare I get to up my bash fu these days -- thanks for the prompt! 🙇‍♀️

[mikealfare]

" ${{ env.HATCH_ADAPTERS}} " =~ " ${{ inputs.dbms_name }} "

This is how you say inputs.dbms_name is in env.HATCH_ADAPTERS in GHA?

[emmyoop]

None of my comments are blocking, just name nits. Only one you should def do is to update the input description. Approving now, pending successful testing!

[mikealfare]

This action includes setting up python

[mikealfare]

There's nothing blocking, but I do think it's worth updating the comment on line 33 and removing the extra setup of python.