Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory wrappers to renamed_relations #9682

Merged

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Feb 27, 2024

resolves #9681

Problem

(Lt. Montgomery Scott voice) Captain, they be missing their wrappers. I can't hold 'em together for much longer.

We need the field wrappers to allow these to be overridden correctly in the runtime.

Solution

Wrap them, so that they are in compliance with other such members of the dataclass.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR (they are in linked adapter PRs)
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@VersusFacit VersusFacit requested a review from a team as a code owner February 27, 2024 05:59
@VersusFacit VersusFacit force-pushed the ADAP-9681/fix_renamed_relations_override_pre_1.8 branch from 170be02 to 1deac9d Compare February 27, 2024 06:10
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (a0372fc) to head (bf52e55).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.7.latest    #9682      +/-   ##
==============================================
- Coverage       86.62%   85.35%   -1.28%     
==============================================
  Files             179      179              
  Lines           26671    26671              
==============================================
- Hits            23105    22764     -341     
- Misses           3566     3907     +341     
Flag Coverage Δ
integration 81.99% <100.00%> (-1.48%) ⬇️
unit 64.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VersusFacit
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Feb 27, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mikealfare
Copy link
Contributor

lol, the codecov check failed because we merged 1.7.latest into this branch, which triggered the check to look at all files, and somehow that was less than 1.7.latest. Magical.

@mikealfare mikealfare merged commit 27e17a7 into 1.7.latest Mar 21, 2024
57 of 58 checks passed
@mikealfare mikealfare deleted the ADAP-9681/fix_renamed_relations_override_pre_1.8 branch March 21, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] renamed_relations not providing overriding hook to adapters
2 participants