-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add factory wrappers to renamed_relations #9682
Add factory wrappers to renamed_relations #9682
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
170be02
to
1deac9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.7.latest #9682 +/- ##
==============================================
- Coverage 86.62% 85.35% -1.28%
==============================================
Files 179 179
Lines 26671 26671
==============================================
- Hits 23105 22764 -341
- Misses 3566 3907 +341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0a8e8da
to
1deac9d
Compare
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
lol, the codecov check failed because we merged 1.7.latest into this branch, which triggered the check to look at all files, and somehow that was less than 1.7.latest. Magical. |
resolves #9681
Problem
We need the
field
wrappers to allow these to be overridden correctly in the runtime.Solution
Wrap them, so that they are in compliance with other such members of the dataclass.
Checklist