Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the renamed relations code #1125

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Fix the renamed relations code #1125

merged 7 commits into from
Mar 21, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Feb 27, 2024 •
edited
Loading

resolves #1123

Need test for this core fix.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Feb 27, 2024
@cla-bot cla-bot bot added the cla:yes label Feb 27, 2024
@mikealfare mikealfare merged commit 4002483 into main Mar 21, 2024
26 checks passed
@mikealfare mikealfare deleted the ADAP-1123/add_test_for_PR_9682_in_core branch March 21, 2024 15:31
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@VersusFacit @github-actions
Fix the renamed relations code (#1125)
c668ca5 
* Add test and move semantics.
* Add field import

---------

Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4002483)
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Merged
mikealfare added a commit that referenced this pull request Mar 21, 2024
@github-actions @VersusFacit @mikealfare
[Backport 1.7.latest] Fix the renamed relations code (#1145)
7c49a91 
* Fix the renamed relations code (#1125)
* Add test and move semantics.
* Add field import

---------

Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit 4002483)

* fix import for de-coupling work

---------

Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Add test for 9682 in core
2 participants
@VersusFacit @mikealfare