-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the renamed relations code against 1.8 #719
Fix the renamed relations code against 1.8 #719
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
8051de7
to
3c3edce
Compare
3c3edce
to
5c9a3fe
Compare
8c14348
to
8a31975
Compare
f8e710a
to
71ca351
Compare
This looks like it might be a dupe. I'll come back after merging the other PR and clean this up if that's the case. |
After fixing |
resolves #693
docs dbt-labs/docs.getdbt.com/#
Problem
There are too many BEGINs and COMMITs in the logs. This is due to how we're nesting macros. This is a problem when drops and renames need to operate together in a single transaction.This is a red herring. The real problem is
renamed_relations
is not evaluating right on instantiation and causing drops where there shouldn't be any.Solution
Change instantiation semantics in core and here. Add test.
Checklist