Remove std feature
#459
Remove std feature
#459
Conversation
All of the existing usages of `std` can be replaced with `alloc`. They are legacy usages from before when liballoc was stabilized.
tarcieri
force-pushed
the
remove-std-feature
branch
from
6fde7d5 to
58866c5
Compare
|
This is odd. The benches now build, but |
|
|
||
| [[bench]] | ||
| name = "dalek_benchmarks" | ||
| harness = false | ||
| required-features = ["rand_core"] |
There was a problem hiding this comment.
@rozbb this is why it doesn't run benchmarks by default. You have to run the with:
$ cargo bench --features rand_core
(sidebar: it might be nice to make the benchmarks deterministic so it doesn't need rand_core)
It's unrelated to this PR but I was getting a build failure without these changes.
Seems related to #447?
There was a problem hiding this comment.
#447 doesn't cause this in itself. cargo bench runs benches currently on release/4.0. Hmm
There was a problem hiding this comment.
Previously std was activated by default, and std activated rand_core/std.
The benchmarks clearly do require rand_core, it's just it used to be "accidentally" enabled by default.
There was a problem hiding this comment.
Ah ok. Then I'll just make a note in the README for now
All of the existing usages of
stdcan be replaced withalloc.They are legacy usages from before when liballoc was stabilized.