-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releasing v4.0.0? #405
Comments
bump |
|
It looks like all of the issues in the list I made are fixed, however I opened one more: #442 |
#449 would be good to address as well |
The two issues have been addressed - SemVer policy was modified: Also re: #449 I'm trying to sneak this PR in: To document the backend selection stuff: #449 is otherwise sorted as the
Also some dependencies were made optional: And @tarcieri got rid of |
The entire checklist is checked off. Seems like aside from e.g. documentation polish there are no remaining blockers for a final release? |
I just need to fix the build.rs for wasm and cross-targets - doing that now - EDIT DONE: Also the backend selection documentation is here now ready: |
Releasing? |
#489 is another change that would be nice to get in before a breaking release. I went ahead and added it to the list, and tagged it |
I closed #491. I don't think there are any remaining release blockers. |
Is there anything the community can help with to make the release happen? |
#380 looks like it might be worth addressing |
Would it be possible to release curve25519-dalek 3.2.2 or 3.3.0 that is exactly the same as 3.2.1 but that allows zeroize versions >=1.4? It is a growing pain to find a working dependency resolution setup with many crates now requiring a zeroize version >=1.4 and curve25519-dalek still forcing zeroize 1.x to <1.4. |
@jplatte we have some prereleases on the 4.0 track already. If you use |
That unfortunately doesn't help because we also depend on |
Ah apologies. We'll be cutting a new x25519 release this week. Sorry for the delays |
@jplatte x25519-dalek rc.2 is out |
As far as I can tell all of the issues/PRs for proposed breaking changes are now closed: #521 I think #523 would be good to land first before a release, ideally getting another prerelease to make sure it doesn't break anything. I've dealt with miscompilation issues in the past with runtime feature autodetection + SIMD code so it'd be really nice to have some confidence that's not going to happen. If we can land that and get another release candidate out, I think we're otherwise finally ready to release. |
FWIW FYI for the SIMD autodetection I replaced our use of |
It looks like this crate has been stuck on 4.0.0-rc.2 since March. That's unusually long for an rc period. A release would help us (zcashd) to eliminate old versions of |
#523 is the main blocker, and it's ready to merge |
Agreed. Sorry, end of semester and beginning of summer internship has been a lot. I think we can cut a new release this week, and maybe the other dalek crates at the same time (there's just 1 outstanding PR in ed- I think that upgrades to the new scalar API) |
It seems #414 is closed again. Does this mean a release could happen? |
Pending issue re:
On 24th consensus seemed two weeks would do for testing - so it could be next week for curve unless ed/x/curve sync release. |
Any thoughts on #546? I opened it just a few hours after the last comment. |
I see there are still questions about ed25519-dalek, but anything holding up a release of x25519-dalek in the meantime? We use x+curve but not ed. |
ICYMI The stable releases are out including curve25519-dalek 4.0.0 + ed/x25519-dalek 2.0.0 🥳 |
Why is this issue still open then? ^^ |
Hello! Just wondering if there is a timeline or any blockers for upgrading the pre-release (v4.0.0-pre.1 currently) to v4.0.0. The opaque-ke library (https://github.com/novifinancial/opaque-ke) is also currently on a pre-release, depending on v4.0.0-pre.1 of this library, and I am waiting on this dependency to upgrade to a full release before doing the same with opaque-ke.
Thanks!
The text was updated successfully, but these errors were encountered: