-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rand_core
optional
#447
Make rand_core
optional
#447
Conversation
rand_core
as optional featurerand_core
optional
93b3c34
to
afde1c0
Compare
As proposed in dalek-cryptography#442 this makes `rand_core` an optional feature that is not covered by the SemVer public API stability guarantees.
afde1c0
to
e08b009
Compare
@@ -36,14 +36,15 @@ bincode = "1" | |||
criterion = { version = "0.4.0", features = ["html_reports"] } | |||
hex = "0.4.2" | |||
rand = "0.8" | |||
rand_core = { version = "0.6", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose not being default is justified by saying most dependencies already specify their own usages of the lower level methods.
This is nearly ready. An annoying issue is that
I think (1) is the right choice. I don't think anyone will miss it. |
@tarcieri thoughts on killing |
Actually this can be solved with weak dependency features if we bump MSRV to 1.60. I think I'd be fine with that actually |
AFAIK nothing in the crate itself actually needs or uses It provides two things:
|
#458 removes activation of |
As proposed in #442 moves
rand_core
as optional featureThis still gets used via dev-dependencies and depending on feature selection tests uses API impl by proxy or mock.