feat: update Axe to v3.2.2 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the now unnecessary custom ARIA lookup table (since DPUB roles are now natively supported by Axe) - in Ace checks, epub:type attribute selectors are replaced by javascript matchers, to work around a limitation of Axe's built-in CSS parser - patch the `only-list-items` check, to allow roles subclassing `listitem` as children of lists - patch the `aria.isAriaRoleAllowedOnElement` function to ensure that roles that do not explicitly define the elements their allowed on are evaluated - disable `landmark-complementary-is-top-level`, which needs further review to see if it makes sense in EPUB. Close #225
danielweck
approved these changes
May 3, 2019
|
Thanks Romain! :) Let's merge this PR, and I will align the l10n PR: #223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are now natively supported by Axe)
matchers, to work around a limitation of Axe's built-in CSS parser
only-list-itemscheck, to allow roles subclassinglistitemas children of listsaria.isAriaRoleAllowedOnElementfunction to ensure thatroles that do not explicitly define the elements their allowed on are
evaluated
landmark-complementary-is-top-level, which needs furtherreview to see if it makes sense in EPUB.
Close #225