Axe monkey patch (aria lookup table) now obsolete? (please check diff) #225
Assignees
Comments
rdeltour
added a commit
that referenced
this issue
May 3, 2019
- remove the now unnecessary custom ARIA lookup table (since DPUB roles are now natively supported by Axe) - in Ace checks, epub:type attribute selectors are replaced by javascript matchers, to work around a limitation of Axe's built-in CSS parser - patch the `only-list-items` check, to allow roles subclassing `listitem` as children of lists - patch the `aria.isAriaRoleAllowedOnElement` function to ensure that roles that do not explicitly define the elements their allowed on are evaluated - disable `landmark-complementary-is-top-level`, which needs further review to see if it makes sense in EPUB. Close #225
danielweck
pushed a commit
that referenced
this issue
May 3, 2019
- remove the now unnecessary custom ARIA lookup table (since DPUB roles are now natively supported by Axe) - in Ace checks, epub:type attribute selectors are replaced by javascript matchers, to work around a limitation of Axe's built-in CSS parser - patch the `only-list-items` check, to allow roles subclassing `listitem` as children of lists - patch the `aria.isAriaRoleAllowedOnElement` function to ensure that roles that do not explicitly define the elements their allowed on are evaluated - disable `landmark-complementary-is-top-level`, which needs further review to see if it makes sense in EPUB. Close #225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@rdeltour I think the changes made by Axe core developers to your code contributions since your original AxeCore PR ( dequelabs/axe-core#584 ) are fine, but please take a look at my long comment in this file to double-check (this is based on AxeCore
3.2.2):https://github.com/daisy/ace/blob/feature/l10n/packages/ace-core/src/scripts/axe-patch-arialookuptable.js#L6
Thanks! :)
The text was updated successfully, but these errors were encountered: