-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Localization / l10n #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al: localized messages)
…wser runtime), fixed CFI generation for root HTML element
…n stub for AceCore (English extraction in progress, French pending...)
…in EPUB package OPF XML (fixed import vs. require in localize source code)
…I, HTTP and unit tests, but by Ace GUI. Also localized KB labels.
…h resulted in "undefined")
…trols needs l10n too (like Ace GUI)
danielweck
added a commit
to daisy/ace-gui
that referenced
this pull request
May 5, 2019
rdeltour
approved these changes
May 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one single detail comment, other looks all good. Thanks!
danielweck
added a commit
to daisy/ace-gui
that referenced
this pull request
May 5, 2019
danielweck
added a commit
that referenced
this pull request
May 5, 2019
danielweck
added a commit
to daisy/ace-gui
that referenced
this pull request
May 5, 2019
Matching Ace Core PR: daisy/ace#223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Related Ace-GUI Pull Request: daisy/ace-gui#40
Typical command line test:
node packages/ace/bin/ace --verbose --force --outdir ./ ~/PATH/TO/book.epub --lang=fr && open ./report.html