Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagit] Remove the Asset Grid prototype that was behind a feature flag #8109

Merged
merged 1 commit into from
May 28, 2022

Conversation

bengotow
Copy link
Collaborator

Summary & Motivation

This PR removes an asset grid feature that we aren't moving forward with. Nothing super fun to see here!

How I Tested These Changes

@bengotow bengotow requested a review from hellendag May 27, 2022 21:49
@vercel
Copy link

vercel bot commented May 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
dagit-storybook ⬜️ Ignored (Inspect) May 27, 2022 at 9:49PM (UTC)
dagster ⬜️ Ignored (Inspect) May 27, 2022 at 9:49PM (UTC)

@bengotow bengotow merged commit 644ab5e into abg/live-data-on-asset-list May 28, 2022
@bengotow bengotow deleted the abg/remove-asset-grid branch May 28, 2022 20:27
bengotow pushed a commit that referenced this pull request May 31, 2022
bengotow pushed a commit that referenced this pull request May 31, 2022
bengotow added a commit that referenced this pull request May 31, 2022
…le (#7996)

* [dagit] Add last materialization, latest run columns to the asset table

* [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109)

Co-authored-by: bengotow <[email protected]>

Co-authored-by: bengotow <[email protected]>
bengotow pushed a commit that referenced this pull request May 31, 2022
bengotow added a commit that referenced this pull request May 31, 2022
…graphs (#8125)

* [dagit] Add last materialization, latest run columns to the asset table

* [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109)

Co-authored-by: bengotow <[email protected]>

* [dagit] Remove the global asset graph in preparation for asset group graphs

Co-authored-by: bengotow <[email protected]>
bengotow pushed a commit that referenced this pull request May 31, 2022
bengotow added a commit that referenced this pull request May 31, 2022
* [dagit] Add last materialization, latest run columns to the asset table

* [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109)

Co-authored-by: bengotow <[email protected]>

* [dagit] Remove the global asset graph in preparation for asset group graphs

* [dagit] Rename isAssetGroup => isHiddenAssetGroupJob for clarity

Co-authored-by: bengotow <[email protected]>
bengotow added a commit that referenced this pull request Jun 1, 2022
…tal flag (#8127)

* [dagit] Add last materialization, latest run columns to the asset table

* [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109)

Co-authored-by: bengotow <[email protected]>

* [dagit] Remove asset graph bundling based on path prefixes, experimental flag

Co-authored-by: bengotow <[email protected]>
OwenKephart pushed a commit that referenced this pull request Jun 1, 2022
…le (#7996)

* [dagit] Add last materialization, latest run columns to the asset table

* [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109)

Co-authored-by: bengotow <[email protected]>

Co-authored-by: bengotow <[email protected]>
bengotow added a commit that referenced this pull request Jun 3, 2022
* [dagit] Add last materialization, latest run columns to the asset table

* [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109)

Co-authored-by: bengotow <[email protected]>

* [dagit] Remove the global asset graph in preparation for asset group graphs

* [dagit] Asset lineage

* Swap out the asset icon

* Lineage tab

* Asset lineage

* Loading states and polish

* Fix tests

* Add “show secondary edges” option, update icons

* Fix vertical divider lines on asset details page

* PR feedback

Co-authored-by: bengotow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants