-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagit] Remove the Asset Grid prototype that was behind a feature flag #8109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
hellendag
approved these changes
May 28, 2022
bengotow
pushed a commit
that referenced
this pull request
May 31, 2022
#8109) Co-authored-by: bengotow <[email protected]>
bengotow
pushed a commit
that referenced
this pull request
May 31, 2022
#8109) Co-authored-by: bengotow <[email protected]>
bengotow
added a commit
that referenced
this pull request
May 31, 2022
…le (#7996) * [dagit] Add last materialization, latest run columns to the asset table * [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109) Co-authored-by: bengotow <[email protected]> Co-authored-by: bengotow <[email protected]>
bengotow
pushed a commit
that referenced
this pull request
May 31, 2022
#8109) Co-authored-by: bengotow <[email protected]>
bengotow
added a commit
that referenced
this pull request
May 31, 2022
…graphs (#8125) * [dagit] Add last materialization, latest run columns to the asset table * [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109) Co-authored-by: bengotow <[email protected]> * [dagit] Remove the global asset graph in preparation for asset group graphs Co-authored-by: bengotow <[email protected]>
bengotow
pushed a commit
that referenced
this pull request
May 31, 2022
#8109) Co-authored-by: bengotow <[email protected]>
bengotow
added a commit
that referenced
this pull request
May 31, 2022
* [dagit] Add last materialization, latest run columns to the asset table * [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109) Co-authored-by: bengotow <[email protected]> * [dagit] Remove the global asset graph in preparation for asset group graphs * [dagit] Rename isAssetGroup => isHiddenAssetGroupJob for clarity Co-authored-by: bengotow <[email protected]>
bengotow
added a commit
that referenced
this pull request
Jun 1, 2022
…tal flag (#8127) * [dagit] Add last materialization, latest run columns to the asset table * [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109) Co-authored-by: bengotow <[email protected]> * [dagit] Remove asset graph bundling based on path prefixes, experimental flag Co-authored-by: bengotow <[email protected]>
OwenKephart
pushed a commit
that referenced
this pull request
Jun 1, 2022
…le (#7996) * [dagit] Add last materialization, latest run columns to the asset table * [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109) Co-authored-by: bengotow <[email protected]> Co-authored-by: bengotow <[email protected]>
bengotow
added a commit
that referenced
this pull request
Jun 3, 2022
* [dagit] Add last materialization, latest run columns to the asset table * [dagit] Remove the Asset Grid prototype that was behind a feature flag (#8109) Co-authored-by: bengotow <[email protected]> * [dagit] Remove the global asset graph in preparation for asset group graphs * [dagit] Asset lineage * Swap out the asset icon * Lineage tab * Asset lineage * Loading states and polish * Fix tests * Add “show secondary edges” option, update icons * Fix vertical divider lines on asset details page * PR feedback Co-authored-by: bengotow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR removes an asset grid feature that we aren't moving forward with. Nothing super fun to see here!
How I Tested These Changes