[dagit] Remove asset graph bundling based on path prefixes, experimental flag #8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
hellendag
approved these changes
May 31, 2022
bengotow
force-pushed
the
abg/remove-global-graph
branch
from
79a86ec to
d588414
Compare
bengotow
force-pushed
the
abg/remove-global-graph-foldering
branch
from
33a5946 to
219737a
Compare
bengotow
force-pushed
the
abg/remove-global-graph
branch
from
d588414 to
32511ad
Compare
bengotow
force-pushed
the
abg/remove-global-graph-foldering
branch
from
219737a to
7cb563d
Compare
added 2 commits
May 31, 2022 14:32
bengotow
force-pushed
the
abg/remove-global-graph-foldering
branch
3 times, most recently
from
85868e6 to
a6a57d3
Compare
bengotow
force-pushed
the
abg/remove-global-graph-foldering
branch
from
a6a57d3 to
861f106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR removes the visual "bundling" of assets on the asset graph into folders. This behavior was primarily useful for the global graph which could display assets. Per discussion with Josh it's unlikely we'll still want this with asset groups, because 1) on asset group graphs, nodes in other asset groups will always be shown as links and 2) on the lineage graph, it's unlikely the bundling of a few upstream assets will make the rendering cleaner. (The graph will be small).
We could potentially bring it back for #2 if we want to, but the code is fairly complex and I'd like to not have it lying around unused.
How I Tested These Changes