[dagit] Rename isAssetGroup => isHiddenAssetGroupJob for clarity #8124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
bengotow
force-pushed
the
abg/remove-global-graph
branch
from
1b99974 to
c05de2f
Compare
bengotow
force-pushed
the
abg/rename-asset-group-job
branch
from
062e9b1 to
d50fbea
Compare
bengotow
force-pushed
the
abg/remove-global-graph
branch
from
c05de2f to
79a86ec
Compare
bengotow
force-pushed
the
abg/rename-asset-group-job
branch
from
d50fbea to
24c7161
Compare
hellendag
approved these changes
May 31, 2022
bengotow
force-pushed
the
abg/remove-global-graph
branch
from
79a86ec to
d588414
Compare
bengotow
force-pushed
the
abg/rename-asset-group-job
branch
from
24c7161 to
034591e
Compare
added 3 commits
May 31, 2022 13:40
bengotow
force-pushed
the
abg/remove-global-graph
branch
from
d588414 to
32511ad
Compare
bengotow
force-pushed
the
abg/rename-asset-group-job
branch
from
034591e to
87334c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Now that we will have actual asset groups displayed in Dagit, the naming of this helper method is very confusing. I'd also like the backend to rename the
ASSET_GROUP_prefix, but we can do that separately!How I Tested These Changes