Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf ceiling bump #26271

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

alangenfeld
Copy link
Member

resolves #25398

How I Tested These Changes

existing coverage

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alangenfeld alangenfeld changed the title attempt protobuf cieling bump attempt protobuf ceiling bump Dec 4, 2024
@alangenfeld alangenfeld marked this pull request as draft December 4, 2024 15:56
@alangenfeld alangenfeld changed the title attempt protobuf ceiling bump protobuf ceiling bump Dec 4, 2024
@alangenfeld alangenfeld force-pushed the al/12-04-attempt_protobuf_cieling_bump branch from 8b1d07b to 5ee6c51 Compare December 4, 2024 16:00
@alangenfeld alangenfeld marked this pull request as ready for review December 4, 2024 17:38
@alangenfeld
Copy link
Member Author

alangenfeld commented Dec 4, 2024

i aspire to add a nightly pipeline test for tracking when the defensive ceiling should get checked and ideally bumped in a follow up

@alangenfeld alangenfeld requested a review from yuhan December 4, 2024 17:47
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth test-all / SKIP_NONE on this one?

@gibsondan
Copy link
Member

(to get all python versions covered)

[NO_SKIP=True][test-all]
@alangenfeld alangenfeld force-pushed the al/12-04-attempt_protobuf_cieling_bump branch from 5ee6c51 to daa8774 Compare December 4, 2024 18:01
@alangenfeld alangenfeld merged commit aaac011 into master Dec 4, 2024
1 check failed
@alangenfeld alangenfeld deleted the al/12-04-attempt_protobuf_cieling_bump branch December 4, 2024 19:02
gibsondan pushed a commit that referenced this pull request Dec 4, 2024
resolves #25398

## How I Tested These Changes

existing coverage
cmpadden pushed a commit that referenced this pull request Dec 5, 2024
resolves #25398

## How I Tested These Changes

existing coverage
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
resolves dagster-io#25398

## How I Tested These Changes

existing coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for protobuf 5.xx
2 participants