-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobuf ceiling bump #26271
Merged
Merged
protobuf ceiling bump #26271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangenfeld
changed the title
attempt protobuf cieling bump
attempt protobuf ceiling bump
Dec 4, 2024
alangenfeld
force-pushed
the
al/12-04-attempt_protobuf_cieling_bump
branch
from
December 4, 2024 16:00
8b1d07b
to
5ee6c51
Compare
i aspire to add a nightly pipeline test for tracking when the defensive ceiling should get checked and ideally bumped in a follow up |
gibsondan
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth test-all / SKIP_NONE on this one?
(to get all python versions covered) |
[NO_SKIP=True][test-all]
alangenfeld
force-pushed
the
al/12-04-attempt_protobuf_cieling_bump
branch
from
December 4, 2024 18:01
5ee6c51
to
daa8774
Compare
gibsondan
pushed a commit
that referenced
this pull request
Dec 4, 2024
resolves #25398 ## How I Tested These Changes existing coverage
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
resolves #25398 ## How I Tested These Changes existing coverage
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
resolves dagster-io#25398 ## How I Tested These Changes existing coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #25398
How I Tested These Changes
existing coverage