Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for protobuf 5.xx #25398

Closed
0x26res opened this issue Oct 21, 2024 · 2 comments · Fixed by #26271
Closed

Allow for protobuf 5.xx #25398

0x26res opened this issue Oct 21, 2024 · 2 comments · Fixed by #26271
Labels

Comments

@0x26res
Copy link

0x26res commented Oct 21, 2024

What's the use case?

Following on #10627 I'd now like to be able to use the version 5.xx of the python protobuf library.

The switch from 4.xx to 5.xx in python corresponds to this release v26.0.

My experience is that the breaking changes are minor, unless using the option always_print_primitive_fields when printing json.

So in theory it's just a matter of changing the setup.py to allow of 5.xx.

Ideas of implementation

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@garethbrickman garethbrickman added the area: python-dependencies Related to Python dependencies label Oct 21, 2024
@je-movers-market
Copy link

je-movers-market commented Dec 3, 2024

The latest dbt-core requires protobuf >=5.0 meaning this is causing a conflict, so current or newer releases of dbt-core are incompatible with Dagster as of right now.

So would surely be good to get this completed ASAP, as I assume the dbt integration is very popular.

@lydialimlh
Copy link

dbt-core 1.8.9 and above requires protobuf >=5.0 , please move the pin so that we can all greenkeep dbt-core.

gibsondan pushed a commit that referenced this issue Dec 4, 2024
resolves #25398

## How I Tested These Changes

existing coverage
cmpadden pushed a commit that referenced this issue Dec 5, 2024
resolves #25398

## How I Tested These Changes

existing coverage
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this issue Dec 16, 2024
resolves dagster-io#25398

## How I Tested These Changes

existing coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants