Skip to content

Commit

Permalink
protobuf ceiling bump (#26271)
Browse files Browse the repository at this point in the history
resolves #25398

## How I Tested These Changes

existing coverage
  • Loading branch information
alangenfeld authored and cmpadden committed Dec 5, 2024
1 parent af3a01c commit 9cd53d7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
4 changes: 2 additions & 2 deletions python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ def get_version() -> str:
f"grpcio>={GRPC_VERSION_FLOOR}",
f"grpcio-health-checking>={GRPC_VERSION_FLOOR}",
"packaging>=20.9",
"protobuf>=3.20.0,<5; python_version<'3.11'", # min protobuf version to be compatible with both protobuf 3 and 4
"protobuf>=4,<5; python_version>='3.11'",
"protobuf>=3.20.0,<6; python_version<'3.11'", # min protobuf version to be compatible with both protobuf 3 and greater
"protobuf>=4,<6; python_version>='3.11'",
"python-dotenv",
"pytz",
"requests",
Expand Down
7 changes: 6 additions & 1 deletion python_modules/libraries/dagster-mlflow/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ def get_version() -> str:
packages=find_packages(exclude=["dagster_mlflow_tests*"]),
include_package_data=True,
python_requires=">=3.9,<3.13",
install_requires=[f"dagster{pin}", "mlflow", "pandas"],
install_requires=[
f"dagster{pin}",
"mlflow",
"pandas",
"protobuf!=5.29.0", # https://github.com/protocolbuffers/protobuf/issues/19430
],
zip_safe=False,
)

0 comments on commit 9cd53d7

Please sign in to comment.