-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MacOS Runner #6580
Update MacOS Runner #6580
Conversation
This reverts commit db012af.
The build passes! I'll come back tomorrow and see if I can get cppcheck working. If not, I'll just revert to this commit. SIde note: Even though the build runs on macos 13, it still targets macos 11. I assume that we want to keep that as-is because we do not want to drop old support unless it becomes necessary. |
No, the plan is to support only the maintained versions macOS, that are currently 12 (Monterey), 13 (Ventura) and 14 (Sonoma). So we should drop macOS 11 Big Sur and update the requirements documentation accordingly. |
…pdate-macos-runner
This reverts commit 2ef8378.
In previous commits, I wrapped a few calls in asserts. It looks like these were being optimized out in the release build.
We've done it! This PR is ready for review!
Notes on reviewing/merging:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job! Thank you!
I could review all the file changes as per your instructions and everything looks very good to me.
I like your approach of adding some cppcheck-suppress
comments instead of trying to fix the problem when it was not super obvious to fix as it minimizes the risk of introducing some bugs, while still highlighting possible improvements.
I just replaced the mandatory macos-11 "Test Sources" check with the new macos-14 one.
I just have one minor suggestion, but you can ignore it if you prefer.
projects/robots/gctronic/e-puck/plugins/remote_controls/e-puck_wifi/Wrapper.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Michel <[email protected]>
Description
GitHub recently deprecated the
macos-11
runner, so all of the tests which rely on that os are failing. This PR updates the runner to thelatestmacos-14
macos-13
image. (There's some bug installing cppcheck on macos-14. I might play around with bumping the cppcheck version later, but I don't have enough info to resolve it as-is.)Hopefully, most of the workflow can be ported without too much hassle, however, if that proves to not be the case, I may have to leave this fix for someone else, as I do not have a mac to debug on.