[CI] Install Swig on Mac #6590
Merged
[CI] Install Swig on Mac #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06a6394.
|
Alright, I'm happy with the current files, and I've managed to link against them in this build. The windows build failure should hopefully be fixed by #6586. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub no longer includes swig by default on the macos 14 runner. Thus, as a result of #6580, builds made on mac with the current ci do not include the java controller api (example). This PR installs swig, fixing the problem. I've also verified that the other dependencies mentioned in the workflow are still installed by default.
Once I verify that this does, in fact, solve the bug, I'll mark this PR as ready for review.