Fix #6578 Devices with Duplicate Names Cause Unexpected Behavior
#6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omichel
requested changes
Jul 10, 2024
tests/other_api/controllers/cpp_device_with_same_name/cpp_device_with_same_name.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
I believe that's fine this way. |
omichel
previously approved these changes
Jul 10, 2024
|
Alright, I've fixed the test suite (for real this time). I'm still blocked from merging because the macos source check is required, so you can either override that check, or we can wait for #6580 to be completed. |
CoolSpy3
deleted the
fix-devices-with-duplicate-names-cause-unexpected-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the controller api to create devices using their device tags instead of their names.
Note: I added a test for this behavior into
other_apibecause that's where I saw the only other C++ test. If it should be moved toapi, let me know, and I can make that change.Related Issues
This pull-request fixes issue #6578.
Tasks
Add the list of tasks of this PR.
Documentation
Robot.md.