Release v2.11.1 #7554
Merged
Release v2.11.1 #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cvat-bot[bot]](https://avatars.githubusercontent.com/in/406724?s=60&v=4){kind=small}
Update develop after v2.11.0
…event (#7511) The first problem is that in the following case, the algorithm would accrue more working time than was actually spent: A |-----------| ---------+------------+------> time B C A, B and C are events. Let's say that Te(A) is the timestamp of the end of A, while T(B) and T(C) are the timestamps of B and C, respectively. The current code in `ClientEventsSerializer.to_internal_value` adjusts `last_timestamp` after processing every event. After A is processed, `last_timestamp` is set to Te(A). After B is processed, `last_timestamp` goes _backwards_ to T(B). So when the algorithm calculates the working time for C, it gets T(C) - T(B), when the correct answer is T(C) - Te(A). The span from T(B) to Te(A) gets counted twice. Fix this by rewriting the algorithm, so that `last_timestamp` (now renamed `previous_end_timestamp`) can only go forwards. ----- The second problem is that the algorithm is unable to calculate the working time for the first event in each batch that the client sends. This is because to calculate working time for an event, you need the timestamp/duration of the previous event, and this information is unavailable for the first event in the batch. Fix this by resending the most recently sent event along with each batch, and using it to initialize the algorithm.
cvat-bot
bot
requested review from
azhavoro,
bsekachev,
mdacoca,
SpecLad and
Marishka17
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7554 +/- ##
=======================================
Coverage 83.52% 83.53%
=======================================
Files 372 372
Lines 39666 39661 -5
Branches 3718 3724 +6
=======================================
- Hits 33131 33129 -2
+ Misses 6535 6532 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Fixed
Fixed a problem with Korean/Chinese characters in attribute annotation mode (Fix bug: Fixed a problem that was overwritten and not inputted when entering Korean #7380)
Fixed incorrect working time calculation in the case where an event occurred during another event (Fix several problems with the calculation of working time per client event #7511)
Fixed working time not being calculated for the first event in each batch sent from the UI (Fix several problems with the calculation of working time per client event #7511)
Submit button is enabled while creating a ground truth job (Disable submit button while creating GT job #7540)