Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for single shape annotation mode #7548

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Mar 4, 2024

Motivation and context

Test for #7486

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov removed the request for review from azhavoro March 4, 2024 12:15
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #7548 (b00da14) into develop (a9333db) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7548   +/-   ##
========================================
  Coverage    83.54%   83.54%           
========================================
  Files          372      372           
  Lines        39661    39661           
  Branches      3724     3724           
========================================
+ Hits         33133    33136    +3     
+ Misses        6528     6525    -3     
Components Coverage Δ
cvat-ui 79.44% <ø> (+0.01%) ⬆️
cvat-server 87.31% <ø> (ø)

cy.visit('auth/login');
cy.login();
cy.headlessCreateTask({
labels: [{ name: labelName, attributes: [], type: 'polygon' }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's add a label for bounding box, ellipse, and points

});
});

describe('Tests basic features of single shape annotation mode', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will propose to add mode describe( for other shapes. It will be almost copy paste.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need to check all the controls for each shape, but we should check that these shapes may be drawn

@bsekachev bsekachev merged commit f52f0f3 into develop Mar 5, 2024
34 checks passed
@bsekachev bsekachev deleted the kl/add-single-shape-mode-test branch March 15, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants