-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single object annotation mode #7486
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7486 +/- ##
===========================================
+ Coverage 83.53% 83.54% +0.01%
===========================================
Files 373 372 -1
Lines 39693 39651 -42
Branches 3718 3724 +6
===========================================
- Hits 33157 33127 -30
+ Misses 6536 6524 -12
|
...ponents/annotation-page/single-shape-workspace/single-shape-sidebar/single-shape-sidebar.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/top-bar/player-navigation.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/top-bar/player-buttons.tsx
Outdated
Show resolved
Hide resolved
We do not have tips in other modes. So, what consistency are you speaking about? It is a default color for Alert and it will be inconsistent to make it gray.
We decided do not set strong restrictions. Finally, users may do what they want. Including annotating many bounding boxes on one frame if this mode is convenient for them because it automatically restarts drawing process.
I removed these buttons to not create custom components for navigation, again, as discussed with Maxim and Nikita. Navigation is possible with default shortcuts that described in shortcuts list. Moreover, by default users do not need even navigate because auto next frame is on. |
Motivation and context
Added query parameter to open specific mode:
?defaultWorkspace=standard
?defaultWorkspace=review
?defaultWorkspace=tags
?defaultWorkspace=single_shape
Query parameters to setup label and number of points in single shape mode:
?defaultLabel=label_name
?defaultPointsCount=1
Additional change: canvas will not trigger unnecessary
canvas.canceled
events when something is done (drawing, merging, etc).Only two things should trigger such events: explicit canvas API call and when something is wrong happened during drawing (e.g. drawn object is not correct)
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.