Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single object annotation mode #7486

Merged
merged 45 commits into from
Feb 27, 2024
Merged

Single object annotation mode #7486

merged 45 commits into from
Feb 27, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Feb 19, 2024

Motivation and context

image

Added query parameter to open specific mode:
?defaultWorkspace=standard
?defaultWorkspace=review
?defaultWorkspace=tags
?defaultWorkspace=single_shape

Query parameters to setup label and number of points in single shape mode:
?defaultLabel=label_name
?defaultPointsCount=1

Additional change: canvas will not trigger unnecessary canvas.canceled events when something is done (drawing, merging, etc).
Only two things should trigger such events: explicit canvas API call and when something is wrong happened during drawing (e.g. drawn object is not correct)

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev marked this pull request as ready for review February 19, 2024 08:21
@bsekachev bsekachev requested a review from nmanovic as a code owner February 19, 2024 08:21
@bsekachev bsekachev requested review from zhiltsov-max and klakhov and removed request for nmanovic February 19, 2024 08:35
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #7486 (bf1dcdf) into develop (6260232) will increase coverage by 0.01%.
Report is 6 commits behind head on develop.
The diff coverage is 80.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7486      +/-   ##
===========================================
+ Coverage    83.53%   83.54%   +0.01%     
===========================================
  Files          373      372       -1     
  Lines        39693    39651      -42     
  Branches      3718     3724       +6     
===========================================
- Hits         33157    33127      -30     
+ Misses        6536     6524      -12     
Components Coverage Δ
cvat-ui 79.44% <86.75%> (+0.03%) ⬆️
cvat-server 87.31% <96.29%> (-0.01%) ⬇️

@klakhov
Copy link
Contributor

klakhov commented Feb 22, 2024

  • The background color of the sidebar is not consistent with our other sidebars, I will suggest to make it gray (maybe with border)
  • If its Single shape mode, maybe we shouldnt allow users to create more that one shape if someone decided to stay on the page?
  • It looks there is no Next button anymore, so it may be confusing what to press. We need to clarify the message about navigation panel and add a next(and maybe prev) frames shortcut hints.
    image

@bsekachev
Copy link
Member Author

bsekachev commented Feb 22, 2024

The background color of the sidebar is not consistent with our other sidebars, I will suggest to make it gray (maybe with border)

We do not have tips in other modes. So, what consistency are you speaking about? It is a default color for Alert and it will be inconsistent to make it gray.

If its Single shape mode, maybe we shouldnt allow users to create more that one shape if someone decided to stay on the page?

We decided do not set strong restrictions. Finally, users may do what they want. Including annotating many bounding boxes on one frame if this mode is convenient for them because it automatically restarts drawing process.

It looks there is no Next button anymore, so it may be confusing what to press. We need to clarify the message about navigation panel and add a next(and maybe prev) frames shortcut hints.

I removed these buttons to not create custom components for navigation, again, as discussed with Maxim and Nikita. Navigation is possible with default shortcuts that described in shortcuts list. Moreover, by default users do not need even navigate because auto next frame is on.

@bsekachev bsekachev requested a review from azhavoro as a code owner February 22, 2024 09:38
@bsekachev bsekachev merged commit 5f20678 into develop Feb 27, 2024
34 checks passed
@bsekachev bsekachev deleted the bs/single_object_mode branch February 28, 2024 14:11
@cvat-bot cvat-bot bot mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants