Intelligent scissors disabling feature

[klakhov]

Motivation and context

Related #2800
Related #3383

• OpenCV intelligent scissors temporarely disabling to create a boundary manually
  
  

• Update UI for interactors' blocking mode
  

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have added description of my changes into CHANGELOG file
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (read github docs)
• I have increased versions of npm packages if it is necessary (cvat-canvas,
  cvat-core, cvat-data and cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.
• I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

[bsekachev]

Hi, the feature is really nice, but I have some thoughts about implementation.

1. Looks like I cannot add a point out of the threshold rectangle (when Block is active). We should allow users to put points anywhere this time, and probably we should hide the threshold this time.
   

2. Why B? We discussed using Ctrl in both intelligent scissors and interactors. Probably it is better to decrease the variety of hotkeys if possible (like in this case when Block plays the same role). BTW, B is a neighbor of N, which stops drawing. It is also inconvenient.

3. Could you please add Block button also for interactors?

4. Let's use <StopOutlined /> icon from antd.

5. IMHO this tooltip is not informative. Maybe something like: "Postpone running the algorithm [B]" is better. You also can suggest your ideas.
   

6. When the cursor is near to the latest point, it disappears and the border shifts. Is it expected?
   

[bsekachev]

@klakhov
Could you please remove WIP from the PR title if it is ready?

[klakhov]

@klakhov
Could you please remove WIP from the PR title if it is ready?

Sure

[bsekachev]

Found two issues with this path:

1. Block using Ctrl does not work (with both scissors and interactors) when start drawing using N hotkey.
2. When use interactors, we can press Block button. It becomes "blue", but requests are still send to the server.

[bsekachev]

When try to finish scissors when the algorithm blocked:

IndexSizeError: Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The source width is 0.

[klakhov]

When try to finish scissors when the algorithm blocked:

IndexSizeError: Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The source width is 0

I've returned blocked mode check to final calculation and this error is gone now.

[bsekachev]

Please add a piece of information to CHANGELOG and update package versions for canvas and ui.

[klakhov]

@aschernov @TOsmanov
Could you please update the user guide about using intelligent scissors according to new changes (pressing Ctrl enables blocking mode)?

@dvkruchinin
Could you please prepare a test for intelligent scissors blocking feature?

[TOsmanov]

@aschernov @TOsmanov
Could you please update the user guide about using intelligent scissors according to new changes (pressing Ctrl enables blocking mode)?

@klakhov , yes, we will update the documentation

[dvkruchinin]

@klakhov
Sure. A test will be updated to cover this feature.

[TOsmanov]

I found that when the restrictive threshold (red square) intelligent scissors (OpenCV) is resized using ctrl+mousewheel triggers the block too, is this expected behavior? I think this is inconvenient as it turns out that the user will not be able to change the size of the threshold without enabling blocking

[bsekachev]

@TOsmanov

I found that when the restrictive threshold (red square) intelligent scissors (OpenCV) is resized using ctrl+mousewheel triggers the block too, is this expected behavior?

It is expected.

it turns out that the user will not be able to change the size of the threshold without enabling blocking

It is possible. Why do you think it does not work? (If you use mousewheel during Ctrl is held, block will not be triggered)

[klakhov]

@TOsmanov
As you can see on this gif, when we are resizing threshold using ctrl+mousewheel block remains disabled. But when the ctrl is pressed without threshold resizing block is triggered.

[TOsmanov]

@bsekachev @klakhov , If you release ctrl a little later than scrolling the mouse wheel, the lock is triggered.

[bsekachev]

@TOsmanov
Could you please provide a .gif where threshold changing happens at the same time with locking?
I cannot reproduce

[TOsmanov]

@bsekachev

I'm using the develop branch with the latest commit 0272384

[bsekachev]

@TOsmanov

Do you have any error message in the browser console this time?

[TOsmanov]

@TOsmanov

Do you have any error message in the browser console this time?

In this moment no.

But I sometimes get an error message in cvat:

OpenCV.js processing error occured
8390056 - Exception catching is disabled, this exception cannot be caught. Compile with -s DISABLE_EXCEPTION_CATCHING=0 > or DISABLE_EXCEPTION_CATCHING=2 to catch.

[klakhov]

@TOsmanov

As we can't easily reproduce this bug, could you please update the documentation and create an issue with more detailed information about your browser/operating system with steps to reproduce this bug?