Update Cypress test to cover "Intelligent scissors blocking feature". #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klakhov Please, review |
dvkruchinin
force-pushed
the
dkru/update-case-101-intelligent-scissors-blocking-feature
branch
from
93a948f
to
71d73c9
Compare
bsekachev
reviewed
Aug 19, 2021
Comment on lines
92
to
96
| cy.get('.cvat_canvas_threshold').should('exist'); | ||
| cy.contains('span', 'Block').click(); | ||
| cy.get('.cvat_canvas_threshold').should('not.exist'); | ||
| cy.contains('span', 'Block').click(); | ||
| cy.get('.cvat_canvas_threshold').should('exist'); |
There was a problem hiding this comment.
Please, check that the block actually work (it creates exactly line user draws without adding any new points)
There was a problem hiding this comment.
Reworked. I allocated it to a separate test. Added checks.
klakhov
approved these changes
Aug 19, 2021
bsekachev
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Update Cypress test to check "Intelligent scissors blocking feature". PR #3510
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.