[#40] Consistent column order for MBCUSTOMQUERY

[daenamkim]

Resolves #40

Result columns will be ordered based on what input index is set for MBCUSTOMQUERY

[shoenseiwaso]

Just read through the code briefly for now. I think this is dependent on #35? I'll review that next!

[shoenseiwaso]

Could events[0] ever be null?

[daenamkim]

Yes, it could be null but throw new Error() will happen before

multibaas-for-google-sheets/src/library/Build.js

Lines 136 to 151 in 15bfb63

	function buildCustomQuery(events, groupBy, orderBy, limit, offset) {
	const query = {
	events: [],
	};
	if (groupBy && groupBy !== '') {
	query.groupBy = groupBy;
	}
	if (orderBy && orderBy !== '') {
	query.orderBy = orderBy;
	}
	// parse and validate header row
	if (events.length < 1) {
	throw new Error(`Expecting a header row followed by one or more data rows, found ${events.length} rows total`);
	}

[daenamkim]

Just read through the code briefly for now. I think this is dependent on #35? I'll review that next!

I think this is not dependent on it because this PR is for selects part not filters

[shoenseiwaso]

Almost there! Some adjustment needed per my comment below.

[shoenseiwaso]

Note that it's not a requirement that each event row is the same event, nor that it has the same aliases. Therefore, I don't think we can just use events[0]:

For example, this is valid:

Which generates the following query:

{
    "events": [
        {
            "eventName": "Transfer",
            "select": [
                {
                    "alias": "abc",
                    "inputIndex": 0,
                    "type": "input"
                },
                {
                    "alias": "ghi",
                    "inputIndex": 2,
                    "type": "input"
                }
            ],
            "filter": {
                "rule": "and",
                "children": [
                    {
                        "operator": "equal",
                        "value": "autotoken",
                        "fieldType": "contract_address_label"
                    }
                ]
            }
        },
        {
            "eventName": "Mint",
            "select": [
                {
                    "alias": "def",
                    "inputIndex": 1,
                    "type": "input"
                },
                {
                    "alias": "jkl",
                    "inputIndex": 2,
                    "type": "input"
                }
            ],
            "filter": {
                "rule": "and",
                "children": [
                    {
                        "operator": "equal",
                        "value": "autotoken",
                        "fieldType": "contract_address_label"
                    }
                ]
            }
        }
    ]
}

With the following result:

{
    "status": 200,
    "message": "success",
    "result": {
        "rows": [
            {
                "abc": null,
                "def": "0xf9450d254a66ab06b30cfa9c6e7ae1b7598c7172",
                "ghi": null,
                "jkl": "100000000000"
            },
            {
                "abc": "0x0000000000000000000000000000000000000000",
                "def": null,
                "ghi": "100000000000",
                "jkl": null
            },
            {
                "abc": "0xf9450d254a66ab06b30cfa9c6e7ae1b7598c7172",
                "def": null,
                "ghi": "10000000000",
                "jkl": null
            },
            {
                "abc": "0xf9450d254a66ab06b30cfa9c6e7ae1b7598c7172",
                "def": null,
                "ghi": "1000000000",
                "jkl": null
            },
            {
                "abc": null,
                "def": "0xf9450d254a66ab06b30cfa9c6e7ae1b7598c7172",
                "ghi": null,
                "jkl": "100000000000"
            },
            {
                "abc": "0x0000000000000000000000000000000000000000",
                "def": null,
                "ghi": "100000000000",
                "jkl": null
            },
            {
                "abc": "0xf9450d254a66ab06b30cfa9c6e7ae1b7598c7172",
                "def": null,
                "ghi": "2000000000",
                "jkl": null
            },
            {
                "abc": null,
                "def": "0xf9450d254a66ab06b30cfa9c6e7ae1b7598c7172",
                "ghi": null,
                "jkl": "870000000"
            },
            {
                "abc": "0x0000000000000000000000000000000000000000",
                "def": null,
                "ghi": "870000000",
                "jkl": null
            },
            {
                "abc": "0xf9450d254a66ab06b30cfa9c6e7ae1b7598c7172",
                "def": null,
                "ghi": "100",
                "jkl": null
            }
        ]
    }
}

I tested this PR by merging #35 into this branch, and indeed, the output is broken: