[#30] Improve event query filter #35
Conversation
| @@ -166,7 +153,6 @@ function buildCustomQuery(events, groupBy, orderBy, limit, offset) { | |||
| // build the event query | |||
| for (let i = 1; i < events.length; i++) { | |||
| const event = events[i]; | |||
|
|
|||
There was a problem hiding this comment.
The section above that validates the number of columns will need to be adjusted. The logic is still setup for when selects and filters were both of size 3.
What we can probably do is just remove this check altogether:
if ((header.length - 1) % 3 !== 0) {
throw new Error(`Expecting number of columns to be divisible by 3 plus 1, found ${header.length} columns total`);
}Since a more comprehensive check is already being done inside extractSelectFilterCounts().
There was a problem hiding this comment.
Sorry. I found the same issue yesterday. I tested complicated filters and worked but simple one didn't work 😓 I will let you know once I fixed this part.
There was a problem hiding this comment.
@shoenseiwaso I have fixed you mentioned and other expected issues. I have tried to test as much as I can but I will try to continue to find out something else. (I setup another environment which cloned but embedded Apps Script with a spreadsheet so you can test independently from now.)
FYI, data should be as follows
…ry-filter Conflicts: test/mbSheetsAddOn.js
|
Once your review is done, I will be happy that you review https://github.com/curvegrid/v2.curvegrid.com/pull/215 too 🙇 |
| const ruleParts = RegExp('^([A-Za-z._]+)([0-9]*)$').exec(rulePath[j]); | ||
| if (ruleParts === null || ruleParts.length < 2) { | ||
| throw new Error(`Invalid rule '${rulePath[j]}' in '${rules}'`); | ||
| } | ||
| const rule = ruleParts[1].toLowerCase(); | ||
| if (rule === '') { | ||
| throw new Error(`Sub-rule is empty in '${rules}'`); |
There was a problem hiding this comment.
Much simpler than what we had, nice!
Part of #30