Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom event queries not working with filters as expected #30

Closed
shoenseiwaso opened this issue Oct 18, 2020 · 0 comments · Fixed by #33
Closed

Custom event queries not working with filters as expected #30

shoenseiwaso opened this issue Oct 18, 2020 · 0 comments · Fixed by #33
Assignees
Labels
bug Something isn't working

Comments

@shoenseiwaso
Copy link
Collaborator

Event Queries no longer require "rule": "input", so the existing custom Event Query code needs to be updated to work with them.

For example, this line:

Probably needs changing to something like (naive fix, does not completely solve the problem):

if (rule !== 'input') {
   node.rule = rule;
}
@shoenseiwaso shoenseiwaso added the bug Something isn't working label Oct 19, 2020
@daenamkim daenamkim self-assigned this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants