Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#30] Fix event queries filters #33

Merged
merged 16 commits into from
Dec 25, 2020
Merged

[#30] Fix event queries filters #33

merged 16 commits into from
Dec 25, 2020

Conversation

daenamkim
Copy link
Collaborator

@daenamkim daenamkim commented Nov 26, 2020 •
edited
Loading

Resolves #30

@daenamkim daenamkim marked this pull request as ready for review November 27, 2020 12:23
shoenseiwaso
shoenseiwaso reviewed Nov 29, 2020
View reviewed changes
Copy link
Collaborator

@shoenseiwaso shoenseiwaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can we update the internal version for testing? Or maybe we have. Let's catch up on Monday.

@daenamkim
Copy link
Collaborator Author

Looking good! Can we update the internal version for testing? Or maybe we have. Let's catch up on Monday.

#37 will help you set an internal version.

I will let you know how to use when this PR is ready.

shoenseiwaso
shoenseiwaso approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@shoenseiwaso shoenseiwaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shoenseiwaso shoenseiwaso self-assigned this Dec 13, 2020
@daenamkim daenamkim mentioned this pull request Dec 22, 2020
Merged
shoenseiwaso
shoenseiwaso reviewed Dec 24, 2020
View reviewed changes
src/library/Validate.js Outdated
'contract_label',
'contract_name',
'contract_address',
'addresses.address',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this line (addresses.address) since it's equivalent to contract_address. Maybe a leftover from the fix?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And apologies for not catching this sooner!

Copy link
Collaborator Author

@daenamkim daenamkim Dec 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I might copied the wrong SQL string in query_field_type.go file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I merge this?

@daenamkim daenamkim merged commit cf1ffa4 into master Dec 25, 2020
@daenamkim daenamkim deleted the 30-fix-event-queries-filters branch December 25, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoenseiwaso shoenseiwaso shoenseiwaso approved these changes

Assignees

@shoenseiwaso shoenseiwaso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom event queries not working with filters as expected
2 participants
@daenamkim @shoenseiwaso