Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JRuby before :command helper hook #612

Merged
merged 1 commit into from
May 12, 2019
Merged

Fix JRuby before :command helper hook #612

merged 1 commit into from
May 12, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented May 5, 2019

Summary

Add full integration test for JRuby helper and make it work.

Details

The before :command hooks are run after the command's environment has already been set up, so instead of modifying Aruba's environment, or the actual environment, we need to modify the command's environment. This change adds a scenario for this feature, and updates the implementation
to make it work.

We also no longer require the helper by default, so requiring by the user will have the desired effect.

Motivation and Context

An attempt was made to fix this feature in #610, but it lacked an integration test so it failed.

How Has This Been Tested?

A scenario was added and the specs were updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I've added tests for my code

@olleolleolle
Copy link
Contributor

Oh, 1.8.7. Ouch!

SyntaxError:
  /home/travis/build/cucumber/aruba/spec/aruba/jruby_spec.rb:9: syntax error, unexpected ':', expecting ')'
  ...es::BasicProcess, environment: command_environment)

PS: This work is super. Thank you for taking the time to build the JRuby support.

The before :command hooks are run after the command's environment has
already been set up, so instead of modifying Aruba's environment, of the
actual environment, we need to modify the command's environment. This
change adds a scenario for this feature, and updates the implementation
to make it work.

We also no longer require the helper by default, so requiring by the
user will have the desired effect.
@mvz mvz force-pushed the fix-jruby-feature-still branch from 8a41b61 to 6e26b0c Compare May 5, 2019 07:42
@mvz mvz merged commit 24ac97d into still May 12, 2019
@mvz mvz deleted the fix-jruby-feature-still branch May 12, 2019 11:27
@mvz mvz mentioned this pull request May 30, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants