Make JRuby before command hook work on Aruba environment #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the JRuby before command helper modify the Aruba environment, rather than the real one.
Details
The JRuby helper sets up a
before :command
hook to set helpful environment variables for JRuby. This changes makes the helper useset_environment_variable
to set Aruba's environment rather than directly modifying the real one.Motivation and Context
When the environment is modified directly, this causes unexpected behavior when using
with_environment
, since that methods will base the changed environment on the environment at startup, rather than the current one. Therefore,with_environment
will unexpectedly undo such modifiections.All this came to light while working on #603.
How Has This Been Tested?
Tests for the JRuby helper were updated to check the result inside a
with_environment
block, thus mimicing the behavior when the hook is used before running a command.Types of changes
Checklist: