Fix JRuby before :command helper hook #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The before :command hooks are run after the command's environment has already been set up, so instead of modifying Aruba's environment, or the actual environment, we need to modify the command's environment. This change adds a scenario for this feature, and updates the implementation to make it work. We also no longer require the helper by default, so requiring by the user will have the desired effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add full integration test for JRuby helper and make it work.
Details
The before :command hooks are run after the command's environment has already been set up, so instead of modifying Aruba's environment, or the actual environment, we need to modify the command's environment. This change adds a scenario for this feature, and updates the implementation to make it work.
We also no longer require the helper by default, so requiring by the user will have the desired effect.
Motivation and Context
This is a forward-port of #612.
How Has This Been Tested?
Cucumber scenario and RSpec specs were added.
Types of changes
Checklist: