Add additional tests to Component #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this behavior is exactly what one would expect, so it should stay as it is. |
|
Yes I agree. However, a developer may fall into this pitfall in the future. This PR is to "document" some of the Component's current behaviours, via some verbose tests. |
|
Something seems to be wrong with pytables in the master |
* master: fix pandas to 0.23.4 for the time being (cta-observatory#937) slimmed down some notebooks and removed poor-quality ones (cta-observatory#933) clean up environment.yml (cta-observatory#932) Print duration of notebooks on travis (cta-observatory#928)
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
==========================================
+ Coverage 78.31% 78.57% +0.26%
==========================================
Files 191 191
Lines 10735 10867 +132
==========================================
+ Hits 8407 8539 +132
Misses 2328 2328
Continue to review full report at Codecov.
|
kosack
approved these changes
Jan 28, 2019
dneise
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some additional tests to
Component.Note
test_change_default_subclass_override, which fails. Do we want a method to be able to change the default of a traitlet for all subclasses? Or should we accept this behaviour for the time being?