Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pandas to 0.23.4 for the time being #937

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Conversation

dneise
Copy link
Member

@dneise dneise commented Jan 28, 2019

I think pandas 0.24.0 is the problem. Let's see what travis says ...

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #937 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
- Coverage   78.48%   78.31%   -0.17%     
==========================================
  Files         191      191              
  Lines       10735    10735              
==========================================
- Hits         8425     8407      -18     
- Misses       2310     2328      +18
Impacted Files Coverage Δ
ctapipe/tools/camdemo.py 55.68% <0%> (-20.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 954aa7b...c5b7e60. Read the comment docs.

Copy link
Contributor

@watsonjj watsonjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work. Maybe we can accept this as a temporary fix, and create a ctapipe issue about this?

@dneise
Copy link
Member Author

dneise commented Jan 28, 2019

Done

@dneise dneise merged commit 5d57cb1 into master Jan 28, 2019
@dneise dneise deleted the fix_pandas_version branch January 28, 2019 13:00
watsonjj added a commit to watsonjj/ctapipe that referenced this pull request Jan 28, 2019
* master:
  fix pandas to 0.23.4 for the time being (cta-observatory#937)
  slimmed down some notebooks and removed poor-quality ones (cta-observatory#933)
  clean up environment.yml (cta-observatory#932)
  Print duration of notebooks on travis (cta-observatory#928)
watsonjj added a commit to watsonjj/ctapipe that referenced this pull request Jan 28, 2019
* master:
  fix pandas to 0.23.4 for the time being (cta-observatory#937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants