Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up environment.yml #932

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Jan 25, 2019

  • remove conda-forge from channel list and only apply it to packages that need it (to avoid upgrading all packages to bleeding-edge versions)
  • remove ctapipe-extra from pip install, go back to using conda package instead

- remove conda-forge from channel list and only apply it to packages that need it (to avoid upgrading all packages to bleeding-edge versions)
- remove ctapipe-extra from pip install, use conda instead
- zeromq
- pyzmq>=17 # needed for correct function of notebooks on OSX
- astropy
- bokeh
- cython
- gammapy
- conda-forge::gammapy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I did not know this was possible

dneise
dneise previously approved these changes Jan 25, 2019
@kosack
Copy link
Contributor Author

kosack commented Jan 25, 2019

If the py3.6 and py 3.7 yaml files are now used for testing, we could clean those up as well and simplify them down to just what is needed to test (since environment.yml contains everything needed for a full interactive setup for a developer, which is a lot more than what is a true dependency)

@dneise
Copy link
Member

dneise commented Jan 25, 2019

Ah right ... good idea.

@dneise
Copy link
Member

dneise commented Jan 25, 2019

the py3.6 and 3.7.yaml are mostly copies of each other. Does anybody know a solution around having these copies?

@kosack
Copy link
Contributor Author

kosack commented Jan 25, 2019

though it doesn't look like there is a large number of packages we can remove... other than maybe gammapy, since it's not used.

@kosack
Copy link
Contributor Author

kosack commented Jan 25, 2019

Does yaml allow something like #include?

@dneise
Copy link
Member

dneise commented Jan 25, 2019

nope: https://stackoverflow.com/a/15437697/1532474

I guess we would need some little tool creating these files from a template and e.g. the PYTHON_VERSION env variable .. could be easily done ...
is it worth it?

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #932 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files         191      191           
  Lines       10735    10735           
=======================================
  Hits         8425     8425           
  Misses       2310     2310

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f2bb5...fa6b95b. Read the comment docs.

@kosack
Copy link
Contributor Author

kosack commented Jan 25, 2019

May not be worth so much effort.

@kosack
Copy link
Contributor Author

kosack commented Jan 25, 2019

for now, I just updated the 3 yml files. We can make it better later, but this should offer some speed up for people who have the full anaconda installed at least since it won't try to upgrade everything.

@kosack kosack merged commit 1322e2f into cta-observatory:master Jan 25, 2019
watsonjj added a commit to watsonjj/ctapipe that referenced this pull request Jan 25, 2019
* master:
  slimmed down some notebooks and removed poor-quality ones (cta-observatory#933)
  clean up environment.yml (cta-observatory#932)
  Print duration of notebooks on travis (cta-observatory#928)
watsonjj added a commit to watsonjj/ctapipe that referenced this pull request Jan 28, 2019
* master:
  fix pandas to 0.23.4 for the time being (cta-observatory#937)
  slimmed down some notebooks and removed poor-quality ones (cta-observatory#933)
  clean up environment.yml (cta-observatory#932)
  Print duration of notebooks on travis (cta-observatory#928)
@kosack kosack deleted the simplify_environment branch May 20, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants