-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up environment.yml #932
Conversation
kosack
commented
Jan 25, 2019
- remove conda-forge from channel list and only apply it to packages that need it (to avoid upgrading all packages to bleeding-edge versions)
- remove ctapipe-extra from pip install, go back to using conda package instead
- remove conda-forge from channel list and only apply it to packages that need it (to avoid upgrading all packages to bleeding-edge versions) - remove ctapipe-extra from pip install, use conda instead
- zeromq | ||
- pyzmq>=17 # needed for correct function of notebooks on OSX | ||
- astropy | ||
- bokeh | ||
- cython | ||
- gammapy | ||
- conda-forge::gammapy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. I did not know this was possible
If the py3.6 and py 3.7 yaml files are now used for testing, we could clean those up as well and simplify them down to just what is needed to test (since environment.yml contains everything needed for a full interactive setup for a developer, which is a lot more than what is a true dependency) |
Ah right ... good idea. |
the py3.6 and 3.7.yaml are mostly copies of each other. Does anybody know a solution around having these copies? |
though it doesn't look like there is a large number of packages we can remove... other than maybe gammapy, since it's not used. |
Does yaml allow something like |
nope: https://stackoverflow.com/a/15437697/1532474 I guess we would need some little tool creating these files from a template and e.g. the PYTHON_VERSION env variable .. could be easily done ... |
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 191 191
Lines 10735 10735
=======================================
Hits 8425 8425
Misses 2310 2310 Continue to review full report at Codecov.
|
May not be worth so much effort. |
for now, I just updated the 3 yml files. We can make it better later, but this should offer some speed up for people who have the full anaconda installed at least since it won't try to upgrade everything. |
* master: slimmed down some notebooks and removed poor-quality ones (cta-observatory#933) clean up environment.yml (cta-observatory#932) Print duration of notebooks on travis (cta-observatory#928)
* master: fix pandas to 0.23.4 for the time being (cta-observatory#937) slimmed down some notebooks and removed poor-quality ones (cta-observatory#933) clean up environment.yml (cta-observatory#932) Print duration of notebooks on travis (cta-observatory#928)