Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set autodownload, fixes doc build #910

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Dec 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #910 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage    82.7%   82.69%   -0.01%     
==========================================
  Files         186      186              
  Lines       10978    10976       -2     
==========================================
- Hits         9079     9077       -2     
  Misses       1899     1899
Impacted Files Coverage Δ
ctapipe/coordinates/__init__.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b35cf...8516257. Read the comment docs.

@maxnoe maxnoe requested review from a team, dneise, kosack and thomasgas December 20, 2018 10:39
@kosack
Copy link
Contributor

kosack commented Jan 3, 2019

do you know what changed to cause this to break in the doc build? It's worked for years. Though I agree it's probably not needed in the docs.

@maxnoe
Copy link
Member Author

maxnoe commented Jan 3, 2019

The server was simply down for about three days.

@maxnoe
Copy link
Member Author

maxnoe commented Jan 3, 2019

See astropy/astropy#8304

@kosack kosack merged commit 4d44bc9 into cta-observatory:master Jan 3, 2019
@maxnoe maxnoe deleted the no_autodownload_iers branch January 3, 2019 13:00
watsonjj added a commit to watsonjj/ctapipe that referenced this pull request Jan 7, 2019
* master: (22 commits)
  Remove all hillas_paramters but version 5, fixes cta-observatory#866  (cta-observatory#904)
  Fix docstring of EventSeeker, fixes cta-observatory#768 (cta-observatory#914)
  Do not set autodownload, fixes doc build (cta-observatory#910)
  Import bokeh.palletes correctly, fixes cta-observatory#911 (cta-observatory#912)
  Fix SST-1M to be DC and not SC. Solves cta-observatory#905 (cta-observatory#908)
  Fix a few test warnings (cta-observatory#902)
  Updates of NectarCam and LSTCam real data eventsource class (cta-observatory#812)
  Implemented FACT image cleaning (cta-observatory#862)
  remove `config=None, tool=None` in some tests (cta-observatory#897)
  Remove flow submodule (got moved to its own package) (cta-observatory#893)
  Cleaning the ctapipe folder. this has been empty for 3 years. (cta-observatory#892)
  Additional metadata from pyhessio, similar to cta-observatory#655 (cta-observatory#895)
  add scikit-learn to install_requires (cta-observatory#877)
  Add .mailmap (cta-observatory#894)
  Fix subarray peek. No more warnings. (cta-observatory#841)
  SimTelEventSource using pyeventio (cta-observatory#864)
  Use sparse neighbor matrix (cta-observatory#826)
  Add test how it should be (cta-observatory#842)
  fix errordef > 0. (cta-observatory#839)
  Fix warning about already closed hessio file (cta-observatory#834)
  ...

# Conflicts:
#	ctapipe/analysis/camera/chargeresolution.py
#	ctapipe/tools/extract_charge_resolution.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants