-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional metadata from pyhessio #655
Conversation
Hi Daniel, |
Hi Samuel, |
The tests currently fail since we don't have a package for the latest pyhessio yet, so when the test-runner installs it, the functions you use are not available. I'll try to make one shortly. We should also add a minimum pyhessio version number in |
Nope, sorry. As far as I recall, it was the case that it wasn't implemented in pyhessio whatsoever, which seems very odd. It's a shame as it'd be an extremely useful feature for machine learning studies with multiple telescopes. |
Why not adding the possibility the retrieve the full run header? e.g. viewcone radius, details on interaction models, wavelength ranges, bunch sizes, how often each shower is used, etc? Here an example of what was useful in the past: MC run header: |
That would be the best, Gernot. I will work on it. |
Are there any updates on adding these header fields? |
Unfortunately, there is nothing new on my side. |
Hi @morcuended!
but I saw that you already started to implement some features. |
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 66.98% 71.88% +4.89%
==========================================
Files 190 204 +14
Lines 10129 11014 +885
==========================================
+ Hits 6785 7917 +1132
+ Misses 3344 3097 -247
Continue to review full report at Codecov.
|
Sure Thomas, go ahead. |
We want to put things like observation height into the instrument/subarray configuration. |
Are these fields covered in the pyeventio? @maxnoe |
Yes, you could access them from the |
Great. So we can close this. 👍 |
* master: (22 commits) Remove all hillas_paramters but version 5, fixes cta-observatory#866 (cta-observatory#904) Fix docstring of EventSeeker, fixes cta-observatory#768 (cta-observatory#914) Do not set autodownload, fixes doc build (cta-observatory#910) Import bokeh.palletes correctly, fixes cta-observatory#911 (cta-observatory#912) Fix SST-1M to be DC and not SC. Solves cta-observatory#905 (cta-observatory#908) Fix a few test warnings (cta-observatory#902) Updates of NectarCam and LSTCam real data eventsource class (cta-observatory#812) Implemented FACT image cleaning (cta-observatory#862) remove `config=None, tool=None` in some tests (cta-observatory#897) Remove flow submodule (got moved to its own package) (cta-observatory#893) Cleaning the ctapipe folder. this has been empty for 3 years. (cta-observatory#892) Additional metadata from pyhessio, similar to cta-observatory#655 (cta-observatory#895) add scikit-learn to install_requires (cta-observatory#877) Add .mailmap (cta-observatory#894) Fix subarray peek. No more warnings. (cta-observatory#841) SimTelEventSource using pyeventio (cta-observatory#864) Use sparse neighbor matrix (cta-observatory#826) Add test how it should be (cta-observatory#842) fix errordef > 0. (cta-observatory#839) Fix warning about already closed hessio file (cta-observatory#834) ... # Conflicts: # ctapipe/analysis/camera/chargeresolution.py # ctapipe/tools/extract_charge_resolution.py
Added new parameters from pyhessio to MCHeaderContainer (as asked in image-extractor#14):
Check this notebook.
Note that some of the implemented fields (prod_site_array, prod_site_coord , prod_site_subarray) are still not retrieving the required information from pyhessio.