Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning the ctapipe folder. #892

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Cleaning the ctapipe folder. #892

merged 2 commits into from
Dec 13, 2018

Conversation

thomasgas
Copy link

I just removed the cextern folder for "External C Libraries". This folder is empty.

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #892 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   73.97%   74.28%   +0.31%     
==========================================
  Files         213      213              
  Lines       12286    12452     +166     
==========================================
+ Hits         9088     9250     +162     
- Misses       3198     3202       +4
Impacted Files Coverage Δ
ctapipe/instrument/subarray.py 77.5% <0%> (-1.4%) ⬇️
ctapipe/io/tests/test_simteleventsource.py 100% <0%> (ø) ⬆️
ctapipe/io/containers.py 100% <0%> (ø) ⬆️
ctapipe/io/simteleventsource.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad39f0...ed73482. Read the comment docs.

@maxnoe maxnoe merged commit 19262ab into cta-observatory:master Dec 13, 2018
@thomasgas thomasgas deleted the remove_cextern branch December 13, 2018 13:33
watsonjj added a commit to watsonjj/ctapipe that referenced this pull request Jan 7, 2019
* master: (22 commits)
  Remove all hillas_paramters but version 5, fixes cta-observatory#866  (cta-observatory#904)
  Fix docstring of EventSeeker, fixes cta-observatory#768 (cta-observatory#914)
  Do not set autodownload, fixes doc build (cta-observatory#910)
  Import bokeh.palletes correctly, fixes cta-observatory#911 (cta-observatory#912)
  Fix SST-1M to be DC and not SC. Solves cta-observatory#905 (cta-observatory#908)
  Fix a few test warnings (cta-observatory#902)
  Updates of NectarCam and LSTCam real data eventsource class (cta-observatory#812)
  Implemented FACT image cleaning (cta-observatory#862)
  remove `config=None, tool=None` in some tests (cta-observatory#897)
  Remove flow submodule (got moved to its own package) (cta-observatory#893)
  Cleaning the ctapipe folder. this has been empty for 3 years. (cta-observatory#892)
  Additional metadata from pyhessio, similar to cta-observatory#655 (cta-observatory#895)
  add scikit-learn to install_requires (cta-observatory#877)
  Add .mailmap (cta-observatory#894)
  Fix subarray peek. No more warnings. (cta-observatory#841)
  SimTelEventSource using pyeventio (cta-observatory#864)
  Use sparse neighbor matrix (cta-observatory#826)
  Add test how it should be (cta-observatory#842)
  fix errordef > 0. (cta-observatory#839)
  Fix warning about already closed hessio file (cta-observatory#834)
  ...

# Conflicts:
#	ctapipe/analysis/camera/chargeresolution.py
#	ctapipe/tools/extract_charge_resolution.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants