Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separation of TelescopeFrame is broken #900

Closed
maxnoe opened this issue Dec 13, 2018 · 2 comments
Closed

separation of TelescopeFrame is broken #900

maxnoe opened this issue Dec 13, 2018 · 2 comments

Comments

@maxnoe
Copy link
Member

maxnoe commented Dec 13, 2018

from ctapipe.coordinates import HorizonFrame, TelescopeFrame
from astropy.coordinates import SkyCoord
import astropy.units as u
 
p = SkyCoord(az=0 * u.deg, alt=1 * u.deg, frame=HorizonFrame())
t1 = SkyCoord(0 * u.deg, 1 * u.deg, frame=TelescopeFrame(pointing_direction=p))
t2 = SkyCoord(0 * u.deg, 0 * u.deg, frame=TelescopeFrame(pointing_direction=p))
print(t1.separation(t2))
print(t1.separation3d(t2))

The first is 90° and the second raises an error about not being able to convert degrees to meter.

@maxnoe
Copy link
Member Author

maxnoe commented Dec 13, 2018

Might be solvable by #899

@maxnoe
Copy link
Member Author

maxnoe commented Dec 14, 2018

Fixed in #896

dneise pushed a commit that referenced this issue Jan 23, 2019
* Start refactoring coordinates

* Update frame attributes for NominalFrame

* Remove weird module check

* Fix coordinate usage in muon code

* Set argv for tool tests, fixes error when using pytest options

* Add roudtrip test

* Names to pointings and docstrings.

* Renaming in tests and coordinates. no abbreviations.

* Fix kwargs

* More renames

* Use QuantityAttributes were appropriate

* Use default=0 for focal_length

* More coordinate fixing

* More coordinate fixes

* Fix coordinate trafo example

* Make HorizonFrame an alias to altaz

* Add test showing it is possible to go from ICRS to camera frame

* Add test that shows separation of planar frame is broken

* Add coordinate attribute back

* Implement nominal and telescopeframe like skyoffsetframe

* Fix imports

* Add missing rotation attribute, call it x and y again

* Allow transforming of AltAz into AltAz without obstime or location

* Use UnitSphericalRepresentation, add tests

* Use approx

* Use correct representation in camera to telescope

* Remove outdated examples

* Fix __all__

* Update docstrings

* Add example to plot stereo showers

* Ugly fix for doc warnings

* Fix invalid syntax

* Fix style issues

* Add test that shows transformation into camera is broken

* Wrap TelescopeFrame and NominalFrame angles at 180°

* Add comment about mapping function

* Rename Telescope and Nominal frame attributes to delta_az, delta_alt, fix camera coordinate trafo

* Do not set astropy config at import

* Remove comment about iers from docs

* Update nominal_frame.py

* Update telescope_frame.py

* Update docstring of camera coordinate

* Start reworking coord docs
watsonjj added a commit to watsonjj/ctapipe that referenced this issue Jan 23, 2019
* master:
  Major coordinate refactoring, fixes cta-observatory#899, cta-observatory#900, cta-observatory#505, cta-observatory#416 (cta-observatory#896)
  speed up is_compatible; makes event_source factory faster (cta-observatory#927)
  Prefix containers (cta-observatory#833)
  remove optional deps in order to fix tests (cta-observatory#925)
  Charge Resolution Update (cta-observatory#827)
  Remove serializer, fixes cta-observatory#887 (cta-observatory#913)
  deleted summary.html - accidentally committed file (cta-observatory#919)

# Conflicts:
#	ctapipe/tools/extract_charge_resolution.py
#	examples/simple_event_writer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants